Skip to content

Conversation

tautschnig
Copy link
Collaborator

Switching from lwp-download to curl to solve problems with SSL
certificates on OS X (cf. #5169). These days, curl is available by
default on most systems anyway, and should thus be easy to use for
everyone. If need be, running make DOWNLOADER=lwp-download would yield
the previous behaviour.

Fixes: #5169

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Switching from lwp-download to curl to solve problems with SSL
certificates on OS X (cf. diffblue#5169). These days, curl is available by
default on most systems anyway, and should thus be easy to use for
everyone. If need be, running `make DOWNLOADER=lwp-download` would yield
the previous behaviour.

Fixes: diffblue#5169
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #5757 (2a5912c) into develop (d1e5b2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5757   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1243     1243           
  Lines       100843   100843           
========================================
  Hits         70243    70243           
  Misses       30600    30600           
Flag Coverage Δ
cproversmt2 43.39% <ø> (ø)
regression 66.56% <ø> (ø)
unit 32.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e5b2c...2a5912c. Read the comment docs.

@tautschnig tautschnig merged commit 0f57d77 into diffblue:develop Jan 17, 2021
@tautschnig tautschnig deleted the curl branch January 17, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glucose-download requires SSL
2 participants