Remove forall_rw_range_set_{r,w}_objects

[tautschnig]

This was useful in the past, but with C++-11 we can use a ranged-for to avoid the iterator altogether.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #5769 (cf2d9ab) into develop (30b4af8) will not change coverage.
The diff coverage is 62.50%.

@@           Coverage Diff            @@
##           develop    #5769   +/-   ##
========================================
  Coverage    69.68%   69.68%           
========================================
  Files         1246     1246           
  Lines       100836   100836           
========================================
  Hits         70263    70263           
  Misses       30573    30573           

Flag	Coverage Δ
cproversmt2	43.42% <62.50%> (ø)
regression	66.65% <62.50%> (ø)
unit	32.21% <43.75%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/analyses/goto_rw.cpp	55.38% <0.00%> (ø)
src/analyses/dependence_graph.cpp	90.82% <100.00%> (ø)
src/analyses/goto_rw.h	69.69% <100.00%> (ø)
src/analyses/reaching_definitions.cpp	79.18% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b4af8...cf2d9ab. Read the comment docs.