Skip to content

[CI] Change method of password input to docker login. #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

Change how the password is being passed to the
docker login command to avoid some security issues
associated with the logging of the password to the
shell history or logs.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Change how the password is being passed to the
docker login command to avoid some security issues
associated with the logging of the password to the
shell history or logs.
@@ -225,5 +225,5 @@ jobs:
run: docker build -t "$IMAGE_TAG" .
- name: Push docker image to DockerHub
run: |
docker login --username=dbcicprover --password=${{ secrets.DOCKERHUB_ACCESS_DB_CI_CPROVER }}
echo ${{ secrets.DOCKERHUB_ACCESS_DB_CI_CPROVER }} | docker login --username=dbcicprover --password-stdin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this works same way as docker login --username=dbcicprover --password-stdin < echo ${{ secrets.DOCKERHUB_ACCESS_DB_CI_CPROVER }} so LGTM

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #5771 (acee1d0) into develop (cb9f69a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5771   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1246     1246           
  Lines       100856   100856           
========================================
  Hits         70276    70276           
  Misses       30580    30580           
Flag Coverage Δ
cproversmt2 43.39% <ø> (ø)
regression 66.65% <ø> (ø)
unit 32.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9f69a...acee1d0. Read the comment docs.

@NlightNFotis NlightNFotis merged commit d3af469 into diffblue:develop Jan 19, 2021
@NlightNFotis NlightNFotis deleted the dockerhub_image_push_fifth_fix branch January 19, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants