Skip to content

Remove non-existent {f,F}orall_valid_objects from clang-format #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

tautschnig
Copy link
Collaborator

This macro does not seem to exist in the code base anymore.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This macro does not seem to exist in the code base anymore.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #5773 (208d47e) into develop (fb32eb1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5773   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1248     1248           
  Lines       100836   100836           
========================================
  Hits         70262    70262           
  Misses       30574    30574           
Flag Coverage Δ
cproversmt2 43.42% <ø> (ø)
regression 66.65% <ø> (ø)
unit 32.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb32eb1...208d47e. Read the comment docs.

@kroening kroening merged commit ea5adcc into diffblue:develop Jan 20, 2021
@tautschnig tautschnig deleted the forall-valid_objects branch January 20, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants