XML output: ensure expressions are valid XML 1.0 #5774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
smowton
as code owners
peterschrammel
approved these changes
Jan 20, 2021
Codecov Report
@@ Coverage Diff @@
## develop #5774 +/- ##
========================================
Coverage 69.67% 69.68%
========================================
Files 1248 1248
Lines 100836 100855 +19
========================================
+ Hits 70262 70278 +16
- Misses 30574 30577 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
xml-escaping
branch
3 times, most recently
from
2a74098 to
0a6370f
Compare
We previously did not perform sanity checks that expressions translate to valid XML 1.0 (which requires that all characters are printable). In most contexts we only handle printable strings, but expressions appearing in goto traces may include non-printable characters. In such cases, just output the underlying array of bytes. This problem was surfaced by SV-COMP benchmarks such as pthread-driver-races/char_generic_nvram_nvram_llseek_nvram_unlocked_ioctl.i (and some of the LDV examples), which use non-printable characters in printk invocations.
tautschnig
force-pushed
the
xml-escaping
branch
from
0a6370f to
15db9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did not perform sanity checks that expressions translate
to valid XML 1.0 (which requires that all characters are printable). In
most contexts we only handle printable strings, but expressions
appearing in goto traces may include non-printable characters. In such
cases, just output the underlying array of bytes.