Skip to content

Loop counter resetting must not result in unlimited unwinding #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

tautschnig
Copy link
Collaborator

Loops with multiple entry points previously resulted in unlimited
unwinding as loop counters were wrongly being reset via edges leaving
one of the loops (and entering the other).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Loops with multiple entry points previously resulted in unlimited
unwinding as loop counters were wrongly being reset via edges leaving
one of the loops (and entering the other).
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #5870 (8330dd3) into develop (e969911) will decrease coverage by 0.00%.
The diff coverage is 89.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5870      +/-   ##
===========================================
- Coverage    72.90%   72.90%   -0.01%     
===========================================
  Files         1423     1423              
  Lines       154216   154196      -20     
===========================================
- Hits        112428   112412      -16     
+ Misses       41788    41784       -4     
Impacted Files Coverage Δ
src/analyses/global_may_alias.cpp 0.00% <0.00%> (ø)
src/analyses/uninitialized_domain.cpp 0.00% <0.00%> (ø)
src/goto-diff/change_impact.cpp 0.00% <ø> (ø)
src/goto-instrument/uninitialized.cpp 0.00% <0.00%> (ø)
src/goto-symex/auto_objects.cpp 21.95% <0.00%> (+0.52%) ⬆️
src/goto-symex/goto_symex.h 92.30% <ø> (ø)
src/goto-symex/symex_function_call.cpp 92.89% <50.00%> (+0.50%) ⬆️
src/goto-programs/goto_program.h 90.06% <80.00%> (+0.03%) ⬆️
jbmc/src/java_bytecode/remove_exceptions.cpp 95.58% <100.00%> (-0.03%) ⬇️
src/analyses/constant_propagator.cpp 94.26% <100.00%> (-0.02%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818fdf2...8330dd3. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... I don't think I want to know what you were doing when you found this issue...

@tautschnig tautschnig merged commit e317683 into diffblue:develop Feb 26, 2021
@tautschnig tautschnig deleted the loop-counter branch February 26, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants