Skip to content

Pull request template: guidance on commits and tests #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

tautschnig
Copy link
Collaborator

To avoid delivering conflicting advice to new contributors, include
guidance on structuring commits and where to place tests in the pull
request template.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

To avoid delivering conflicting advice to new contributors, include
guidance on structuring commits and where to place tests in the pull
request template.
@tautschnig tautschnig requested a review from a team as a code owner April 13, 2021 07:39
@tautschnig tautschnig merged commit 5601657 into diffblue:develop Apr 13, 2021
@tautschnig tautschnig deleted the regression-guidelines branch April 13, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants