Skip to content

Use check-sat-assuming #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Use check-sat-assuming #6041

merged 2 commits into from
Apr 16, 2021

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds support for SMT-LIB2 check-sat-assuming.
Instead of assing the assumptions as (hard) constraints, use the SMT-LIB
command check-sat-assuming, which has been designed for this particular
use-case.
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #6041 (f2350c9) into develop (211b539) will increase coverage by 0.24%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6041      +/-   ##
===========================================
+ Coverage    74.13%   74.37%   +0.24%     
===========================================
  Files         1444     1444              
  Lines       157442   157448       +6     
===========================================
+ Hits        116720   117104     +384     
+ Misses       40722    40344     -378     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.h 100.00% <ø> (ø)
src/solvers/smt2/smt2_conv.cpp 60.30% <52.94%> (-0.07%) ⬇️
src/ansi-c/c_typecheck_expr.cpp 60.19% <0.00%> (+0.09%) ⬆️
src/ansi-c/expr2c.cpp 58.14% <0.00%> (+0.19%) ⬆️
src/ansi-c/c_typecheck_code.cpp 70.63% <0.00%> (+0.48%) ⬆️
src/big-int/bigint.cc 88.85% <0.00%> (+0.74%) ⬆️
src/util/simplify_expr_floatbv.cpp 94.57% <0.00%> (+0.77%) ⬆️
src/ansi-c/parser.y 62.30% <0.00%> (+1.30%) ⬆️
src/util/irep_serialization.cpp 92.66% <0.00%> (+1.83%) ⬆️
src/util/expr_initializer.cpp 83.55% <0.00%> (+4.60%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5914d75...f2350c9. Read the comment docs.

@kroening kroening merged commit b233b7e into develop Apr 16, 2021
@kroening kroening deleted the use_check_sat_assuming branch April 16, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants