-
Notifications
You must be signed in to change notification settings - Fork 280
Add cmake
to the title of the VS with cmake
CI job
#6153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So that it is clearer when looking at the list of jobs that the difference between them is `cmake` versus `make`.
Codecov Report
@@ Coverage Diff @@
## develop #6153 +/- ##
===========================================
- Coverage 74.95% 74.88% -0.08%
===========================================
Files 1447 1447
Lines 158197 158196 -1
===========================================
- Hits 118580 118468 -112
- Misses 39617 39728 +111
Continue to review full report at Codecov.
|
Did something go wrong with CI here? |
I believe branch protection settings need amending. So whoever has access to those settings will need to take care of this. |
@peterschrammel Could you look at the protection settings? |
Fixed |
Once it is merged I can cmake it required. |
@peterschrammel Can you please update the configuration? |
So that it is clearer when looking at the list of jobs that the difference between them is
cmake
versusmake
.Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).N/AMy commit message includes data points confirming performance improvements (if claimed).None claimed