Skip to content

Conversation

thomasspriggs
Copy link
Contributor

So that it is clearer when looking at the list of jobs that the difference between them is cmake versus make.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message). N/A
  • My commit message includes data points confirming performance improvements (if claimed). None claimed
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

So that it is clearer when looking at the list of jobs that the
difference between them is `cmake` versus `make`.
@thomasspriggs thomasspriggs requested a review from a team as a code owner May 26, 2021 09:39
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #6153 (4b4c910) into develop (437420d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6153      +/-   ##
===========================================
- Coverage    74.95%   74.88%   -0.08%     
===========================================
  Files         1447     1447              
  Lines       158197   158196       -1     
===========================================
- Hits        118580   118468     -112     
- Misses       39617    39728     +111     
Impacted Files Coverage Δ
src/solvers/flattening/bv_pointers.cpp 82.66% <100.00%> (-0.04%) ⬇️
src/ansi-c/literals/convert_float_literal.cpp 73.80% <0.00%> (-19.05%) ⬇️
src/ansi-c/c_typecheck_code.cpp 66.26% <0.00%> (-11.66%) ⬇️
src/ansi-c/c_storage_spec.cpp 86.84% <0.00%> (-10.53%) ⬇️
src/util/pointer_offset_size.cpp 86.94% <0.00%> (-5.23%) ⬇️
src/util/std_types.cpp 83.95% <0.00%> (-4.94%) ⬇️
src/util/std_code.h 91.50% <0.00%> (-3.23%) ⬇️
src/util/simplify_expr_floatbv.cpp 94.57% <0.00%> (-1.56%) ⬇️
src/ansi-c/c_typecheck_expr.cpp 60.12% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82fea4...4b4c910. Read the comment docs.

@TGWDB
Copy link
Contributor

TGWDB commented May 26, 2021

Did something go wrong with CI here?

@tautschnig
Copy link
Collaborator

Did something go wrong with CI here?

I believe branch protection settings need amending. So whoever has access to those settings will need to take care of this.

@thomasspriggs
Copy link
Contributor Author

thomasspriggs commented May 26, 2021

@peterschrammel Could you look at the protection settings?

@peterschrammel
Copy link
Member

Fixed

@peterschrammel
Copy link
Member

peterschrammel commented May 26, 2021

Once it is merged I can cmake it required.

@TGWDB TGWDB merged commit cc12235 into diffblue:develop May 27, 2021
@tautschnig
Copy link
Collaborator

@peterschrammel Can you please update the configuration?

@thomasspriggs thomasspriggs deleted the tas/vs_cmake_name branch May 27, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants