Fix evaluation of decreases clause #6269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatPadhi
added
bugfix
aws
SaswatPadhi
force-pushed
the
decreases-fix
branch
from
dee5293 to
872a8c0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6269 +/- ##
===========================================
- Coverage 76.17% 75.90% -0.28%
===========================================
Files 1484 1492 +8
Lines 162317 162724 +407
===========================================
- Hits 123646 123513 -133
- Misses 38671 39211 +540
Continue to review full report at Codecov.
|
martin-cs
approved these changes
Aug 4, 2021
SaswatPadhi
force-pushed
the
decreases-fix
branch
from
872a8c0 to
e8f195a
Compare
|
Thanks for taking a look @martin-cs. @feliperodri could you please take a look too? |
feliperodri
requested changes
Aug 4, 2021
SaswatPadhi
force-pushed
the
decreases-fix
branch
from
e8f195a to
0beeb6f
Compare
feliperodri
approved these changes
Aug 4, 2021
`__CPROVER_decreases` clauses on loops were evaluated outside of loop iterations (before checking the loop guard), which was buggy. We fix this behavior in this commit. The clause is now evaluated inside the loop block (after the loop guard is satisfied).
SaswatPadhi
force-pushed
the
decreases-fix
branch
from
0beeb6f to
dbb5163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__CPROVER_decreasesclauses on loops were evaluated outside of loop iterations, which was buggy. In this PR, we fix this behavior: decreases clause is evaluated inside the loop block (after the loop guard is satisfied).The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).