Feature/ai logging #6285
Merged
Feature/ai logging #6285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cs
requested review from
chrisr-diffblue and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6285 +/- ##
========================================
Coverage 75.96% 75.97%
========================================
Files 1508 1508
Lines 163292 163378 +86
========================================
+ Hits 124052 124129 +77
- Misses 39240 39249 +9
Continue to review full report at Codecov.
|
martin-cs
force-pushed
the
feature/ai-logging
branch
from
c374dfa to
4a04652
Compare
|
@peterschrammel and @chrisr-diffblue sorry to hassle but is there any chance of a quick review? This is just adding progress and debugging logging to the abstract interpreter. At lower verbosity levels it should be completely functionality neutral. |
chrisr-diffblue
approved these changes
Aug 13, 2021
|
Thanks for the fast review @chrisr-diffblue . I will fix the formatting and then merge. |
added 3 commits
August 13, 2021 12:24
The legacy ait interface is preserved by creating a local null_message_handlert and then passing this as a reference to the parent constructor. This is not ideal but does preserve behaviour.
This includes debugging to dump out the full history and domain as we go which allows tracing of the full computation if needed.
This does not check whether the debug output is actually sensible or useful, just whether it is present at the different --verbosity levels.
martin-cs
force-pushed
the
feature/ai-logging
branch
from
4a04652 to
91e4706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging to the core of the abstract interpretation algorithm.