Skip to content

[CI] Change order of arguments to signtool.exe. #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

According to the documentation at https://docs.microsoft.com/en-us/dotnet/framework/tools/signtool-exe,
any options should be coming before the file_name, denoting the file
to be signed.

This should stop the options being seemingly ignored, and causing issues
during the release process.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Sep 22, 2021
@NlightNFotis NlightNFotis requested a review from a team as a code owner September 22, 2021 10:43
@NlightNFotis NlightNFotis force-pushed the fix_windows_release_arg_order branch from 5d039ab to af09077 Compare September 22, 2021 10:56
According to the documentation at https://docs.microsoft.com/en-us/dotnet/framework/tools/signtool-exe,
any options should be coming before the `file_name`, denoting the file
to be signed.

This should stop the options being seemingly ignored, and causing issues
during the release process.
@NlightNFotis NlightNFotis force-pushed the fix_windows_release_arg_order branch from af09077 to 14553de Compare September 22, 2021 10:57
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #6358 (af09077) into develop (9d774a7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head af09077 differs from pull request most recent head 14553de. Consider uploading reports for the commit 14553de to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6358      +/-   ##
===========================================
- Coverage    75.90%   75.90%   -0.01%     
===========================================
  Files         1515     1515              
  Lines       164002   164004       +2     
===========================================
+ Hits        124482   124483       +1     
- Misses       39520    39521       +1     
Impacted Files Coverage Δ
src/goto-analyzer/unreachable_instructions.cpp 90.95% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4b5c6...14553de. Read the comment docs.

@NlightNFotis NlightNFotis merged commit cdaa7a1 into diffblue:develop Sep 22, 2021
@NlightNFotis NlightNFotis deleted the fix_windows_release_arg_order branch September 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants