Add construction of value exprts from smt terms.
#6519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macros are used in order to make the duplications in the test inputs manageable. However clang-format needs to be off for these macros as the way clang-format formats them makes them less readable.
thomasspriggs
requested review from
chrisr-diffblue,
kroening,
NlightNFotis,
peterschrammel,
tautschnig and
TGWDB
as code owners
TGWDB
approved these changes
Dec 8, 2021
Codecov Report
@@ Coverage Diff @@
## develop #6519 +/- ##
===========================================
- Coverage 76.11% 75.98% -0.13%
===========================================
Files 1548 1578 +30
Lines 166308 180897 +14589
===========================================
+ Hits 126589 137460 +10871
- Misses 39719 43437 +3718
Continue to review full report at Codecov.
|
NlightNFotis
approved these changes
Dec 9, 2021
| TEST_CASE("Value expr construction from smt.", "[core][smt2_incremental]") | ||
| { | ||
| optionalt<smt_termt> input_term; | ||
| optionalt<exprt> expected_result; | ||
|
|
||
| using rowt = std::pair<smt_termt, exprt>; | ||
|
|
||
| // clang-format off | ||
| #define UNSIGNED_BIT_VECTOR_TESTS(bits) \ |
There was a problem hiding this comment.
Ohh, I like that. 👍🏻
Better for self-documenting code than the comment based approach we had.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds construction of value
exprts from smt terms.