Codify grouping and order of includes #6620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening and
peterschrammel
as code owners
peterschrammel
approved these changes
Feb 1, 2022
NlightNFotis
approved these changes
Feb 1, 2022
CI jobs running on github are less likely to temporarily fail when using mirrors from github.com. The (transient?) failure seen most recently was: ``` git clone -b v5.10 --depth=1 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux_5_10 Cloning into 'linux_5_10'... remote: aborting due to possible repository corruption on the remote side. fatal: early EOF fatal: fetch-pack: invalid index-pack output ``` This commit seeks to address this kind of problem.
Codecov Report
@@ Coverage Diff @@
## develop #6620 +/- ##
========================================
Coverage 76.64% 76.64%
========================================
Files 1579 1579
Lines 181485 181479 -6
========================================
- Hits 139103 139101 -2
+ Misses 42382 42378 -4
Continue to review full report at Codecov.
|
clang-format supports describing groups of includes via regular expressions and assigning priorities to them. The include file corresponding to an implementation will always have priority 0. Other priorities are now set in the clang-format configuration. Includes not specified will be auto-assigned INT_MAX as priority.
tautschnig
force-pushed
the
cleanup/clang-format-includes
branch
from
4ce3db5 to
3b7b19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format supports describing groups of includes via regular
expressions and assigning priorities to them. The include file
corresponding to an implementation will always have priority 0. Other
priorities are now set in the clang-format configuration. Includes not
specified will be auto-assigned INT_MAX as priority.
If people disagree with the proposed order (implementation-header file; util; goto-programs; any other directory; current directory; standard library) then please just voice this.