Skip to content

bug when using preincrement on _Bool #7046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

bug when using preincrement on _Bool #7046

merged 2 commits into from
Aug 3, 2022

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening marked this pull request as ready for review July 30, 2022 19:28
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #7046 (23d10ec) into develop (a1ecd93) will increase coverage by 0.00%.
The diff coverage is 78.07%.

@@           Coverage Diff            @@
##           develop    #7046   +/-   ##
========================================
  Coverage    77.88%   77.88%           
========================================
  Files         1569     1569           
  Lines       180894   180989   +95     
========================================
+ Hits        140882   140962   +80     
- Misses       40012    40027   +15     
Impacted Files Coverage Δ
src/solvers/smt2_incremental/object_tracking.h 100.00% <ø> (ø)
src/util/dstring.h 100.00% <ø> (ø)
src/util/std_expr.h 92.09% <0.00%> (-0.91%) ⬇️
src/solvers/prop/prop_conv_solver.cpp 87.50% <16.66%> (-1.65%) ⬇️
src/solvers/smt2/smt2_conv.cpp 68.76% <16.66%> (-0.11%) ⬇️
src/solvers/flattening/boolbv.cpp 87.08% <25.00%> (-0.76%) ⬇️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 88.56% <92.85%> (+0.26%) ⬆️
src/goto-instrument/horn_encoding.cpp 73.24% <100.00%> (+0.53%) ⬆️
src/solvers/smt2_incremental/object_tracking.cpp 98.41% <100.00%> (+0.41%) ⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 99.68% <100.00%> (+<0.01%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197c68c...23d10ec. Read the comment docs.

This adds two tests that expose bugs when doing preincrement on C99 _Bool.
@kroening kroening merged commit 3c5c267 into develop Aug 3, 2022
@kroening kroening deleted the Bool_tests branch August 3, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants