Skip to content

Only add assumption scope if not empty #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

FrNecas
Copy link
Contributor

@FrNecas FrNecas commented Nov 16, 2022

The GOTO trace may contain instructions from the global scope (e.g. assigning a value to a global variable). In such case, the scope should be global, i.e. no assumption.scope as per the witness specification.

I found this issue during 2LS SV-comp preruns due to witnesslint failing on a singular assumption.scope data tag. There is no scope on global variable definitions, therefore the scope should not be added.

@peterschrammel this should later be cherry-picked to 2LS's fork

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message). [Sorry, I am not very familiar with the code base and don't really know how to test changes around witnesses]
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The GOTO trace may contain instructions from the global scope (e.g.
assigning a value to a global variable). In such case, the scope should
be global, i.e. no assumption.scope as per the witness specification.

Signed-off-by: František Nečas <frantisek.necas@protonmail.com>
@tautschnig tautschnig merged commit df8ae3b into diffblue:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants