Skip to content

Add myself as a codeowner for the Rust API #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

NlightNFotis
Copy link
Contributor

It makes sense since I'm the primary driver of the project to assume
code ownership of the project so that it moves faster and I get notified
of any changes to it.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Feb 1, 2023
@NlightNFotis NlightNFotis added the Rust API Issues pertaining to the CBCM Rust API label Feb 1, 2023
CODEOWNERS Outdated
@@ -45,6 +45,7 @@
/src/analyses/ @martin-cs @peterschrammel @chris-ryder
/src/pointer-analysis/ @martin-cs @peterschrammel @chris-ryder
/src/libcprover-cpp @NlightNFotis @thomasspriggs @esteffin @TGWDB @peterschrammel
/src/libcprover-rust @NlightNFotis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a single codeowner/point of review, or more than one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded to include everyone from the team that indicated a willingness to do so.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 78.16% // Head: 78.50% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (884a15d) compared to base (9b681ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7513      +/-   ##
===========================================
+ Coverage    78.16%   78.50%   +0.34%     
===========================================
  Files         1663     1663              
  Lines       191297   191297              
===========================================
+ Hits        149518   150174     +656     
+ Misses       41779    41123     -656     
Impacted Files Coverage Δ
src/util/bitvector_expr.h 97.41% <0.00%> (+0.23%) ⬆️
src/util/std_expr.h 93.15% <0.00%> (+0.26%) ⬆️
src/util/std_code.cpp 41.89% <0.00%> (+1.35%) ⬆️
src/util/expr.h 97.14% <0.00%> (+1.90%) ⬆️
src/util/dstring.h 100.00% <0.00%> (+3.22%) ⬆️
src/util/symbol_table_base.cpp 67.85% <0.00%> (+3.57%) ⬆️
src/util/source_location.cpp 94.00% <0.00%> (+6.00%) ⬆️
src/util/simplify_utils.cpp 93.67% <0.00%> (+6.75%) ⬆️
src/util/union_find.cpp 82.81% <0.00%> (+7.81%) ⬆️
src/util/type.h 98.68% <0.00%> (+7.89%) ⬆️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NlightNFotis NlightNFotis merged commit 71faa2d into diffblue:develop Feb 1, 2023
@NlightNFotis NlightNFotis deleted the add_rust_codeowner branch February 1, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust API Issues pertaining to the CBCM Rust API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants