Skip to content

Conversation

tautschnig
Copy link
Collaborator

When using computed gotos, the addresses of labels are taken. These are compile-time constants that are safe to use in initializers of objects with static lifetime.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When using computed gotos, the addresses of labels are taken. These are
compile-time constants that are safe to use in initializers of objects
with static lifetime.
@kroening kroening enabled auto-merge March 9, 2023 12:58
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (f02532a) 78.36% compared to head (00f95f8) 78.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7585      +/-   ##
===========================================
+ Coverage    78.36%   78.50%   +0.14%     
===========================================
  Files         1670     1670              
  Lines       191768   191769       +1     
===========================================
+ Hits        150277   150551     +274     
+ Misses       41491    41218     -273     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_expr.cpp 76.76% <100.00%> (+0.04%) ⬆️
src/util/std_expr.h 93.15% <0.00%> (+0.17%) ⬆️
src/util/ssa_expr.cpp 94.17% <0.00%> (+0.97%) ⬆️
src/util/expr.h 97.14% <0.00%> (+1.90%) ⬆️
src/util/type.h 100.00% <0.00%> (+2.98%) ⬆️
src/util/dstring.h 100.00% <0.00%> (+3.22%) ⬆️
src/util/string_utils.cpp 93.51% <0.00%> (+4.62%) ⬆️
src/big-int/bigint.hh 97.36% <0.00%> (+5.26%) ⬆️
src/util/string_container.h 100.00% <0.00%> (+18.18%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kroening kroening merged commit ed48947 into diffblue:develop Mar 9, 2023
@tautschnig tautschnig deleted the bugfixes/static-computed-goto branch March 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants