Skip to content

Cleanup implementation of goto binary reading #7635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This refactoring PR is preparatory work for #7633

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thomasspriggs thomasspriggs force-pushed the tas/refactor_goto_binary_read branch 2 times, most recently from 7872b3a to c9366f0 Compare March 30, 2023 16:35
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (417d362) 78.36% compared to head (53bb8fd) 78.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7635      +/-   ##
===========================================
+ Coverage    78.36%   78.51%   +0.14%     
===========================================
  Files         1671     1671              
  Lines       191829   191845      +16     
===========================================
+ Hits        150328   150620     +292     
+ Misses       41501    41225     -276     
Impacted Files Coverage Δ
src/goto-programs/read_bin_goto_object.cpp 90.22% <100.00%> (+1.33%) ⬆️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Because it deserialises two separate things and this helps make the
functions smaller and separate the two separate steps.
So that the symbol table reading function does not need access to the
goto functions.
This function is not exposed in the header file and it always returns
`false` therefore we can apply this simplification.
The proceding control flow always returns before this point therefore we
can use `UNREACHABLE` to make the control flow more explicit.
Because it is not mutated after it is read from file.
@thomasspriggs thomasspriggs force-pushed the tas/refactor_goto_binary_read branch from c9366f0 to 53bb8fd Compare March 31, 2023 10:14
@thomasspriggs thomasspriggs marked this pull request as ready for review March 31, 2023 10:17
@tautschnig tautschnig enabled auto-merge March 31, 2023 11:16
@tautschnig tautschnig merged commit cd53c8d into diffblue:develop Mar 31, 2023
@tautschnig tautschnig mentioned this pull request Apr 3, 2023
3 tasks
@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants