Skip to content

Maintain state across multiple linker calls #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Maintain state across multiple linker calls #7722

wants to merge 3 commits into from

Conversation

tautschnig
Copy link
Collaborator

We need to pick up renamings of symbols that are not local to a translation unit from the target symbol table.

Fixes: #7720

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this May 18, 2023
tautschnig added 3 commits May 23, 2023 15:05
@tautschnig
Remove typecheckt interface from linkingt
7df3543 
There is no particular benefit in this inheritance. Also prepare for
maintaining state across multiple calls to the linker by making the
source symbol table an argument specific to each linking call.
@tautschnig
Moving linking out of language front-ends
1ab27d9 
Type checking in languages now takes care of a single translation unit
only, and returns a symbol table. Linking is now invoked by
`language_filest`.

This is in preparation of maintaining linker state across multiple
translation units.
@tautschnig
Maintain state across multiple linker calls
256d609 
To be done: We need to pick up renamings of symbols that are not local
to a translation unit from the target symbol table.

Fixes: diffblue#7720
@tautschnig tautschnig force-pushed the bugfixes/7720-stateful-linking branch from f43077a to 256d609 Compare May 23, 2023 15:06
@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label Jul 10, 2023
@tautschnig
Copy link
Collaborator Author

Closing in favour of the much simplier approach taken in #8167.

@tautschnig tautschnig closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening Awaiting requested review from kroening kroening will be requested when the pull request is marked ready for review kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

@feliperodri feliperodri Awaiting requested review from feliperodri feliperodri will be requested when the pull request is marked ready for review feliperodri is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 will be requested when the pull request is marked ready for review remi-delmas-3000 is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs will be requested when the pull request is marked ready for review martin-cs is a code owner

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB will be requested when the pull request is marked ready for review TGWDB is a code owner

Assignees

@tautschnig tautschnig

Labels
aws Bugs or features of importance to AWS CBMC users bugfix work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linker does not identify the correct function with external linkage
2 participants
@tautschnig @feliperodri