Skip to content

Conversation

tautschnig
Copy link
Collaborator

These were added to the CMake configuration, but were missing an entry and configuration file for make-based builds.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

These were added to the CMake configuration, but were missing an entry
and configuration file for make-based builds.
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the omission. LGTM.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (26b8027) 78.54% compared to head (af7044a) 78.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7742      +/-   ##
===========================================
- Coverage    78.54%   78.45%   -0.10%     
===========================================
  Files         1688     1688              
  Lines       193001   193015      +14     
===========================================
- Hits        151596   151427     -169     
- Misses       41405    41588     +183     

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit b155fb0 into diffblue:develop May 31, 2023
@tautschnig tautschnig deleted the bugfixes/goto-inspect-test-makefile branch May 31, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants