Improvements to duplicate_per_byte to simplify the input value #7887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
duplicate_per_byte
contains an efficient implementation wheninit_expr
is a constant.However this feature is never used as the shadow memory module almost always wraps
init_expr
with a typecast to the type of the shadow memory.This PR applies a simplification step in
duplicate_per_byte
, callingsimplify_expr
, so that the casts may be removed and the more efficient implementation will be used.This PR also adds unit tests to make sure the simplification step is performed.