Skip to content

Conversation

NlightNFotis
Copy link
Contributor

We have an issue with our CI in that the job for vs2022 is failing to execute some tests that depend on a python script, because the python interpreter fails to be instantiated (that is, it fails during binary initialisation by failing to link against a DLL).

This version of Python appears to be preinstalled in some fashion (either it comes with chocolatey, or is installed as a transitive dependency of other dependencies of our build), but the end result is that we fail at running some of the tests.

This change appears in our experiments to fix the situation with the bad binary that is installed for Python with chocolatey, by removing the folder from the path, we don't trigger execution with the bad binary.

This appears in our experiments to fix the situation with the
bad binary that is installed for Python with chocolatey.
@NlightNFotis NlightNFotis requested a review from a team as a code owner September 26, 2023 16:51
Copy link
Contributor

@esteffin esteffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@esteffin esteffin changed the title Remove line that adds chocolatey/bin folder to GITHUB_PATH. Remove line that adds chocolatey/bin folder to GITHUB_PATH from CI. Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (74bb276) 78.85% compared to head (5685932) 78.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7920      +/-   ##
===========================================
- Coverage    78.85%   78.38%   -0.48%     
===========================================
  Files         1697     1697              
  Lines       195379   195379              
===========================================
- Hits        154072   153147     -925     
- Misses       41307    42232     +925     

see 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NlightNFotis NlightNFotis merged commit e02fd74 into diffblue:develop Sep 26, 2023
@NlightNFotis NlightNFotis deleted the fix_python_ci branch September 26, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants