unary_exprt::check and nullary_exprt::check #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jan 6, 2024
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
This adds unary_exprt::check(expr), which checks that the expression is indeed unary. This follows the same pattern as binary_exprt::check and ternary_exprt::check.
kroening
force-pushed
the
unary_exprt_check
branch
from
990e6f6
to
b4f1f10
Compare
Three wrongly hand-crafted bit-vector constants are fixed. Bit-vector constants are hex, and must not use leading zeros.
This adds nullary_exprt::check(expr), which checks that the expression is indeed nullary. This follows the same pattern as binary_exprt::check and ternary_exprt::check.
kroening
force-pushed
the
unary_exprt_check
branch
from
b4f1f10
to
550251b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8151 +/- ##
===========================================
- Coverage 79.10% 79.09% -0.01%
===========================================
Files 1695 1695
Lines 196596 196578 -18
===========================================
- Hits 155517 155488 -29
- Misses 41079 41090 +11 ☔ View full report in Codecov by Sentry. |
tautschnig
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.