Skip to content

introduce update_bit_exprt #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

introduce update_bit_exprt #8190

merged 1 commit into from
Feb 7, 2024

Conversation

kroening
Copy link
Member

@kroening kroening commented Feb 6, 2024

This adds update_bit_exprt, for a single-bit update, analogously to extractbit and extractbits.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening changed the title introduce update_bit_exprt introduce update_bit_exprt Feb 6, 2024
@kroening kroening marked this pull request as ready for review February 6, 2024 13:09
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (547b1a8) 79.68% compared to head (6925475) 79.66%.

Files Patch % Lines
src/util/bitvector_expr.h 0.00% 21 Missing ⚠️
src/util/bitvector_expr.cpp 0.00% 14 Missing ⚠️
src/solvers/flattening/boolbv_with.cpp 0.00% 12 Missing ⚠️
src/solvers/smt2/smt2_conv.cpp 11.11% 8 Missing ⚠️
src/solvers/flattening/boolbv_update_bit.cpp 0.00% 2 Missing ⚠️
src/solvers/flattening/boolbv.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8190      +/-   ##
===========================================
- Coverage    79.68%   79.66%   -0.03%     
===========================================
  Files         1681     1682       +1     
  Lines       195319   195375      +56     
===========================================
+ Hits        155636   155639       +3     
- Misses       39683    39736      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a test that actually uses that - at least in hw-cbmc.

@kroening
Copy link
Member Author

kroening commented Feb 6, 2024

It would be great to have a test that actually uses that - at least in hw-cbmc.

Coming. This is a bit of a chicken-and-egg problem.

This adds update_bit_exprt, for a single-bit update, analogously to
extractbit and extractbits.
@kroening kroening merged commit aff6268 into develop Feb 7, 2024
@kroening kroening deleted the updatebit_exprt branch February 7, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants