Skip to content

Remove parsert::clear and all of its overrides #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

tautschnig
Copy link
Collaborator

Re-use of parsers should no longer be necessary now that they aren't objects of static lifetime anymore. Consequently, there is no need to "clear," and instead only a subset of the instructions is required in constructors.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Re-use of parsers should no longer be necessary now that they aren't
objects of static lifetime anymore. Consequently, there is no need to
"clear," and instead only a subset of the instructions is required in
constructors.
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (1fd7011) to head (14715d9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8244   +/-   ##
========================================
  Coverage    79.64%   79.65%           
========================================
  Files         1684     1683    -1     
  Lines       195606   195549   -57     
========================================
- Hits        155791   155765   -26     
+ Misses       39815    39784   -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 6ad485d into diffblue:develop Apr 2, 2024
@tautschnig tautschnig deleted the cleanup/remove-parsert-clear branch April 2, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants