Skip to content

Conversation

kroening
Copy link
Member

@kroening kroening commented May 17, 2024

This enables designating further assertions as fatal.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This enables designating further assertions as fatal.
@kroening kroening added C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't. labels May 17, 2024
@kroening kroening marked this pull request as ready for review May 17, 2024 07:25
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 78.25%. Comparing base (c320360) to head (5c5895b).

Files Patch % Lines
src/ansi-c/goto-conversion/goto_check_c.cpp 4.54% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8297      +/-   ##
===========================================
- Coverage    78.35%   78.25%   -0.10%     
===========================================
  Files         1721     1721              
  Lines       188278   188510     +232     
  Branches     18460    18455       -5     
===========================================
  Hits        147523   147523              
- Misses       40755    40987     +232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 52c3dbb into develop Jun 3, 2024
@tautschnig tautschnig deleted the goto-check-c-fatal branch June 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants