Skip to content

fixup! fix exprt::opX accesses in linker_script_merge #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

tautschnig
Copy link
Collaborator

In one case 7bf94f1 wrongly turned index_exprt::op0 into index_exprt::index() when that should be ::array().

Running tests on aarch64 was thus broken (but we don't yet do that in CI).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (c9653bd) to head (2e054be).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/goto-cc/linker_script_merge.cpp 64.70% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8657      +/-   ##
===========================================
- Coverage    80.36%   80.36%   -0.01%     
===========================================
  Files         1686     1686              
  Lines       206981   206981              
  Branches        73       73              
===========================================
- Hits        166340   166337       -3     
- Misses       40641    40644       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kroening kroening assigned tautschnig and unassigned kroening Jun 18, 2025
In one case 7bf94f1 wrongly turned
`index_exprt::op0` into `index_exprt::index()` when that should be
`::array()`.

Running tests on aarch64 was thus broken (but we don't yet do that in
CI).
@tautschnig tautschnig force-pushed the fixup-linker-script-merge branch from d056803 to 2e054be Compare June 20, 2025 19:45
@tautschnig tautschnig merged commit 0bb2d02 into diffblue:develop Jun 20, 2025
39 of 40 checks passed
@tautschnig tautschnig deleted the fixup-linker-script-merge branch June 20, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants