-
Notifications
You must be signed in to change notification settings - Fork 282
Add support for reading GOTO functions from JSON #8713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e39b7d5
to
f4fd908
Compare
Use an approach similar to contracts regression tests to extract parameters for multiple tools from a single line in the .desc file. This avoids overly fragmenting regression tests.
The C front-end created symbols that had the function set to an empty string. This was not accurately represented in the JSON representation, but also shouldn't be used at all. Thus, changing the parser rather than the JSON serialisation.
We were previously only printing a subset, making it impossible to restore a `source_locationt` from its JSON representation.
The JSON output of a `source_locationt` is different from generic `irept`. Also, make `try_get_{bool,string}` publicly available for subsequent re-use.
We must include all information required to re-produce a goto program from its JSON representation.
f4fd908
to
c1f0d84
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #8713 +/- ##
===========================================
+ Coverage 80.39% 80.43% +0.03%
===========================================
Files 1688 1695 +7
Lines 207435 208285 +850
Branches 73 73
===========================================
+ Hits 166776 167524 +748
- Misses 40659 40761 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
32637a1
to
1a105d5
Compare
kroening
approved these changes
Sep 19, 2025
Adds a parser for JSON-encoded `goto_functionst` and support to `symtab2gb` to optionally read such from a file and store them in `goto_functions` of a `goto_modelt`.
1a105d5
to
6d3ce5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: please review commit-by-commit.
Adds a parser for JSON-encoded
goto_functionst
and support tosymtab2gb
to optionally read such from a file and store them ingoto_functions
of agoto_modelt
.