Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureCI and GitLabCI don't have Panic Recovery like GithubCI and BitbucketCI #768

Closed
ajaxian79 opened this issue Nov 12, 2023 · 1 comment · Fixed by #769
Closed

AzureCI and GitLabCI don't have Panic Recovery like GithubCI and BitbucketCI #768

ajaxian79 opened this issue Nov 12, 2023 · 1 comment · Fixed by #769

Comments

@ajaxian79
Copy link
Contributor

Of the four supported CI tools only Github and Bitbucket have code that recovers from a panic, for example from GitHub CI

	defer func() {
		if r := recover(); r != nil {
			log.Println(fmt.Sprintf("stacktrace from panic: \n" + string(debug.Stack())))
			err := usage.SendLogRecord(githubActor, fmt.Sprintf("Panic occurred. %s", r))
			if err != nil {
				log.Printf("Failed to send log record. %s\n", err)
			}
			os.Exit(1)
		}
	}()

It would be great if this could be written in a manner that makes it not only support all existing CIs but also as new CIs are added this change could cover those as well.

I am going to take a stab at solving this issue myself and submitting the fix as a PR.

ajaxian79 pushed a commit to ajaxian79/digger that referenced this issue Nov 12, 2023
@ajaxian79
Copy link
Contributor Author

Submitted Pull Request here #769

YouTube Video where I made these changes is here https://youtu.be/tzFjxQvP77g

motatoes pushed a commit that referenced this issue Nov 19, 2023
* Fix for #768

* Address PR Comments

---------

Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>
motatoes added a commit that referenced this issue Nov 20, 2023
* fix(deps): update module github.com/aws/aws-sdk-go to v1.47.13

* fix Github's GetChangedFiles() to also return previous filenames (#788)

* Fix Github's GetChangedFiles() to return previous filenames

* tests

* Update README.md

* Pass plan policy outputs to access policy before apply (#777)

* Pass plan policy output to access policy; run plan+policy before apply
---------

Co-authored-by: motatoes <moe.habib9@gmail.com>

* Docs: add ee setup guide

* fix(deps): update module github.com/aws/aws-sdk-go to v1.48.0

* Fix for #768 (#769)

* Fix for #768

* Address PR Comments

---------

Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>

* fix typo in readme (#803)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Francois L <17277004+fleroux514@users.noreply.github.com>
Co-authored-by: Utpal Nadiger <nadiger.utpal@gmail.com>
Co-authored-by: Igor Zalutski <izalutski@gmail.com>
Co-authored-by: ajaxian79 <blaketullysmith@gmail.com>
Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>
Co-authored-by: Max Brydak <57046745+mbrydak@users.noreply.github.com>
motatoes added a commit that referenced this issue Dec 26, 2023
* fix(deps): update module github.com/aws/aws-sdk-go to v1.47.13

* fix Github's GetChangedFiles() to also return previous filenames (#788)

* Fix Github's GetChangedFiles() to return previous filenames

* tests

* Update README.md

* Pass plan policy outputs to access policy before apply (#777)

* Pass plan policy output to access policy; run plan+policy before apply
---------

Co-authored-by: motatoes <moe.habib9@gmail.com>

* Docs: add ee setup guide

* fix(deps): update module github.com/aws/aws-sdk-go to v1.48.0

* Fix for #768 (#769)

* Fix for #768

* Address PR Comments

---------

Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>

* fix typo in readme (#803)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Francois L <17277004+fleroux514@users.noreply.github.com>
Co-authored-by: Utpal Nadiger <nadiger.utpal@gmail.com>
Co-authored-by: Igor Zalutski <izalutski@gmail.com>
Co-authored-by: ajaxian79 <blaketullysmith@gmail.com>
Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>
Co-authored-by: Max Brydak <57046745+mbrydak@users.noreply.github.com>
Former-commit-id: d97d94e
motatoes added a commit that referenced this issue May 16, 2024
* fix(deps): update module github.com/aws/aws-sdk-go to v1.47.13

* fix Github's GetChangedFiles() to also return previous filenames (#788)

* Fix Github's GetChangedFiles() to return previous filenames

* tests

* Update README.md

* Pass plan policy outputs to access policy before apply (#777)

* Pass plan policy output to access policy; run plan+policy before apply
---------

Co-authored-by: motatoes <moe.habib9@gmail.com>

* Docs: add ee setup guide

* fix(deps): update module github.com/aws/aws-sdk-go to v1.48.0

* Fix for #768 (#769)

* Fix for #768

* Address PR Comments

---------

Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>

* fix typo in readme (#803)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Francois L <17277004+fleroux514@users.noreply.github.com>
Co-authored-by: Utpal Nadiger <nadiger.utpal@gmail.com>
Co-authored-by: Igor Zalutski <izalutski@gmail.com>
Co-authored-by: ajaxian79 <blaketullysmith@gmail.com>
Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>
Co-authored-by: Max Brydak <57046745+mbrydak@users.noreply.github.com>
Former-commit-id: d97d94e
ben-of-codecraft pushed a commit to ben-of-codecraft/digger that referenced this issue May 21, 2024
* Fix for diggerhq#768

* Address PR Comments

---------

Co-authored-by: Blake Tullysmith <btullysmith@bluescalesolutions.com>
Former-commit-id: 03f8a22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant