Revert telemetry changes #1184
Merged
Revert telemetry changes #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1724aae.
vdmkenny
reviewed
Feb 20, 2024
| @@ -11,6 +11,7 @@ type DiggerConfigYaml struct { | |||
| Projects []*ProjectYaml `yaml:"projects"` | |||
| AutoMerge *bool `yaml:"auto_merge"` | |||
| Workflows map[string]*WorkflowYaml `yaml:"workflows"` | |||
| Telemetry *bool `yaml:"telemetry,omitempty"` | |||
There was a problem hiding this comment.
Please keep in mind that people who have not read the changelog or the thread about the issues around telemetry might not see this and update their config flag. Since the feature is opt-out, having the old flag set will re-enable telemetry for these users.
There was a problem hiding this comment.
it will be mentioned in the next release notes and we will do a psa about it
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
Revert telemetry changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1179
send_usage_datatotelemetryto make it more clear