Add invalid params error handling for Saml::Bindings::HTTPPost.receive_message
#176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating a great gem.
I created this PR because I found one problem while developing a project using this gem. Please check if you like.
Summary
If both
SAMLRequest
andSAMLResponse
are nil in the request parameter, the argumentnil
is specified inSaml::Encoding#decode_64
and the exceptionNoMethodError
is raised.See: https://github.com/digidentity/libsaml/blob/master/lib/saml/bindings/http_post.rb#L23
This isn't friendly to developers, so I've added an exception class
Saml::Errors::InvalidParams
to detect this.