Add invalid params error handling for Saml::Bindings::HTTPRedirect.receive_message
#180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saml::Bindings::HTTPRedirect.receive_message
decodes the request parameterSAMLRequest
orSAMLResponse
, but if neither exists, it becomesnil
. Then,nil
is specified in the argument of Saml :: Encoding.decode_64` method, and the following error occurs.This error isn't kind to the developer, so I've added a process to check that the input parameter has a
SAMLRequest
orSAMLResponse
and raise an exception if it doesn't.This is similar to the next PR. #176