Fix some incorrect dependencies in alga_derive
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p. Remove incorrect dependencies of Quasigroup/Loop on the second operation of CommutativeRing (which must only be a semigroup). Remove second instance of Ring on the second operation of CommutativeRing (it led to two AbstractRing definitions which were then conflicting).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three small changes. I was unable to get any of the tests in
alga_derive_testto run (even before modifying things), but in my personal use case (implementing an integral domain, so in particular multiplication does not have two-sided inverses) I have expanded the macro#[alga_derive(RingCommutative(Additive, Multiplicative))]and it now behaves as expected.The total changes are: