Fixed a (presumed) typo in documentation in matrix_view.rs #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a (presumed) typo in documentation in matrix_view.rs. Previously it says fixed_view and fixed_slice returns a matrix with `(R::dim(), CView::dim())` consecutive components. I just changed R to RView, because presumably this is a typo.
Ralith
requested changes
Apr 22, 2024
|
sorry, so should they all say |
|
That makes sense to me, at least! |
Fixed a (presumed) typo in documentation in matrix_view.rs. Previously it says fixed_view and fixed_slice returns a matrix with `(RView, CView)` consecutive components. As per-input, and after re-reading the documentation and source code. Seems like RView and CView should be used instead of RView::dim() and CViem::dim().
|
with this pull request I changed the documentation for |
Ralith
reviewed
Apr 23, 2024
Fixed spacing in documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a (presumed) typo in documentation in matrix_view.rs.
Previously it says fixed_view and fixed_slice returns a matrix with
(R::dim(), CView::dim())consecutive components. I just changed R to RView, because presumably this is a typo.This is my first time submitting a pull request, and I would be more than happy to take any input.