Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShapeType precludes custom shapes #3

Closed
Ralith opened this issue Feb 1, 2021 · 0 comments · Fixed by #6
Closed

ShapeType precludes custom shapes #3

Ralith opened this issue Feb 1, 2021 · 0 comments · Fixed by #6

Comments

@Ralith
Copy link
Contributor

Ralith commented Feb 1, 2021

ShapeType's options are all rather specific, preventing an implementer of Shape from introducing significantly diverse custom shapes. A ShapeType::Custom might be missing, or perhaps Shape::shape_type should return Option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve serialization performance by avoiding the use of erased-serde. dimforge/parry
1 participant
@Ralith