Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent definitions of feature ID #46

Open
Ralith opened this issue Aug 3, 2021 · 0 comments
Open

Inconsistent definitions of feature ID #46

Ralith opened this issue Aug 3, 2021 · 0 comments

Comments

@Ralith
Copy link
Contributor

Ralith commented Aug 3, 2021

In some places, parry uses the FeatureId enum, but TrackedContent uses a plain u32 for its feature IDs. This is also easily confused with the subshape u32s in ContactManifold, which identify logical shapes but not individual geometric features of a single shape (i.e. not necessarily a specific face, edge, or vertex). It's also unclear whether feature IDs in contact manifolds are scoped to shapes or subshapes, whereas FeatureIds necessarily must be shape-scoped since they're e.g. returned by PointQuery.

See also Discord discussion. Opening an issue for tracking purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant