Skip to content

added missing filter parameters #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2022
Merged

added missing filter parameters #110

merged 4 commits into from
May 28, 2022

Conversation

jcyuan
Copy link
Contributor

@jcyuan jcyuan commented May 23, 2022 •
edited
Loading

added those missing filter parameters on query APIs. (added as the last parameter and optional for those APIs, so that it's compatible with older version)

added for:

castRay
castRayAndGetNormal
intersectionsWithRay
intersectionWithShape
intersectionsWithPoint
projectPoint
castShape
intersectionsWithShape

btw, didn't add for this one becase it's in another branch #104, have to wait to be merged first.

projectPointAndGetFeature

@jcyuan jcyuan changed the title filter parameters is missing added missing filter parameters May 23, 2022
@sebcrozet sebcrozet merged commit 52bd447 into dimforge:master May 28, 2022
@sebcrozet
Copy link
Member

Thanks!

@jcyuan jcyuan mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcyuan @sebcrozet