fixed dynamic bodies not waking when their joint motor changed #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavlig
changed the title
Vrixyz
requested changes
May 29, 2024
There was a problem hiding this comment.
Thanks for your report and suggestion for a fix ! Additionally to my comment (for which I do not have a solution to suggest right now), a reproduction / test / example would help with tackling that issue.
In the meantime it should be possible to wake up the body manually.
Comment on lines
+209
to
+210
| /// The flag indicating that motor settings were changed from outside | ||
| pub motor_changed: bool, |
There was a problem hiding this comment.
While I appreciate the "low number of lines" this PR ends up, this would add state to an otherwise "configuration" or "data oriented" struct, I'm not sure this is the right place to add that.
Vrixyz
added
C-User experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wheels on my vehicle stop spinning they might fall asleep in rapier and using motors didnt wake them up so this is my fix