Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QueryFilterFlags values having a bitshift too much #673

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fix QueryFilterFlags values having a bitshift too much #673

merged 5 commits into from
Jul 8, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jul 8, 2024

@Vrixyz Vrixyz requested review from sebcrozet and removed request for sebcrozet July 8, 2024 13:17
@Vrixyz Vrixyz mentioned this pull request Jul 8, 2024
Closed
sebcrozet
sebcrozet approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@sebcrozet sebcrozet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let’s add a ### Modified entry to the changelog saying Divided by two the value of each QueryFilterFlags variant so that the smallest one is 1 instead of 2 (fixes a bug in rapier.js).

@Vrixyz Vrixyz merged commit 87ada34 into dimforge:master Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with sensors
2 participants
@Vrixyz @sebcrozet