fix: prevent stalling requests #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there is an unnecessary
awaitsinceverifyKeydoes not return a promise and while using this, I also noticed that it can stall requests when there is an incoming request with empty signature / timestamp headers.It is because it throws an error here but that error is never caught, so it never returns the 401 message.
Express (and similar middleware handlers) also do not care about errors on their own, so if you use it the way you do it in the example, it will stall the request if the headers are missing and this error is thrown.
This PR fixes it by just catching the error(s) from
verifyKeyin the middleware and returning a 401 message instead, as it was supposed to do.