rateLimitInfo.requestLimit is undefined

[niekcandaele]

Please describe the problem you are having in as much detail as possible:

When trying to log info about the rateLimit event, rateLimitInfo.requestLimit is undefined.

Include a reproducible code sample here, if possible:

client.on('rateLimit', info => {
    console.log(`Discord API rateLimit reached! ${info.requestLimit} max requests allowed`);
});

Which results in this log line: Discord API rateLimit reached! undefined max requests allowed

Further details:

• discord.js version: 11.4.2
• Node.js version: 11.10.0
• Operating system: Ubuntu 18.10
• Priority this issue should have – please be realistic and elaborate if possible: low

Not sure how I should test rate limit locally, happy to do so if someone can tell me the best method

• I have also tested the issue on latest master, commit hash:

[almostSouji]

The data is emitted as data.limit:

discord.js/src/client/rest/RequestHandlers/Sequential.js

Lines 97 to 102 in b5df860

	this.client.emit(RATE_LIMIT, {
	limit: this.requestLimit,
	timeDifference: this.timeDifference,
	path: item.request.path,
	method: item.request.method,
	});

But documented as data.requestLimit, probably mixed up the naming from the this context:

discord.js/src/client/rest/RequestHandlers/Sequential.js

Lines 88 to 96 in b5df860

	/**
	* Emitted when the client hits a rate limit while making a request
	* @event Client#rateLimit
	* @param {Object} rateLimitInfo Object containing the rate limit info
	* @param {number} rateLimitInfo.requestLimit Number of requests that can be made to this endpoint
	* @param {number} rateLimitInfo.timeDifference Delta-T in ms between your system and Discord servers
	* @param {string} rateLimitInfo.method HTTP method used for request that triggered this event
	* @param {string} rateLimitInfo.path Path used for request that triggered this event
	*/

This is correctly documented on the master docs, I will PR the doc fix for 11.4-dev shortly

[niekcandaele]

Ahhh thank you very much! :)

[SpaceEEC]

Fixed with the referenced commit ^