Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: make JSON_LD schema consistent with our microdata in core #269

Merged
merged 2 commits into from
Nov 22, 2023
Merged

FIX: make JSON_LD schema consistent with our microdata in core #269

merged 2 commits into from
Nov 22, 2023

Conversation

arpitjalan
Copy link
Member

CvX
CvX reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a prettier pass and a specs update?

@arpitjalan
Copy link
Member Author

@CvX Fixed linting issues and updated specs.

@arpitjalan arpitjalan merged commit ad1b7c9 into main Nov 22, 2023
@arpitjalan arpitjalan deleted the jsonld-improvements branch November 22, 2023 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@CvX CvX CvX approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpitjalan @CvX