Feat/circom 2.2.0

RELEASES.md

@@ -1,4 +1,24 @@
 # Release notes
+## October 07, 2024 circom 2.2.0
+#### New features
+- Buses: more information [here](https://github.com/iden3/circom/blob/master/mkdocs/docs/circom-language/buses.md).
+
+#### Changes
+- input/output keywords are the first token in declarations (though having it after "signal" is still accepted).
+- The default option for constraint simplification is --O1 (instead of --O2 which was the default until now). More information in [here](https://github.com/iden3/circom/blob/master/mkdocs/docs/circom-language/circom-insight/simplification.md).
+
+#### Extensions
+- Allowing array assignments of different sizes. 
+- Improving error reports when parsing.
+- Improving documentation.
+
+#### Fixed bugs
+- Main with no inputs is now executed once.
+- Fixing complement function to depend on the prime number used.
+- Applying modulo prime number to any constant in the circuit.
+- Fixing minor panic: the number of signals passed to the anonymous component must be equal to the actual number of inputs.
+
+
 ## April 23, 2024 circom 2.1.9
 
 #### Extensions 

circom/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "circom"
-version = "2.1.9"
+version = "2.2.0"
 authors = ["Costa Group UCM","iden3"]
 edition = "2018"
 

circom/src/input_user.rs

@@ -269,9 +269,8 @@ mod input_processing {
                     else {Ok(SimplificationStyle::O2(no_rounds))}} 
                 else { Result::Err(eprintln!("{}", Colour::Red.paint("invalid number of rounds"))) }
             },
-
             (false, false, false, true) => Ok(SimplificationStyle::O2(usize::MAX)),
-            (false, false, false, false) => Ok(SimplificationStyle::O2(usize::MAX)),
+            (false, false, false, false) => Ok(SimplificationStyle::O1),
         }
     }
 
@@ -413,7 +412,7 @@ mod input_processing {
                     .long("O1")
                     .hidden(false)
                     .takes_value(false)
-                    .help("Only applies signal to signal and signal to constant simplification")
+                    .help("Only applies signal to signal and signal to constant simplification. This is the default option")
                     .display_order(460)
             )
             .arg(

circom/src/parser_user.rs

@@ -1,12 +1,15 @@
 use super::input_user::Input;
+use program_structure::constants::UsefulConstants;
 use program_structure::error_definition::Report;
 use program_structure::program_archive::ProgramArchive;
 use crate::VERSION;
 
 
 pub fn parse_project(input_info: &Input) -> Result<ProgramArchive, ()> {
     let initial_file = input_info.input_file().to_string();
-    let result_program_archive = parser::run_parser(initial_file, VERSION, input_info.get_link_libraries().to_vec(), input_info.save_ast, input_info.ast_path.clone());
+    //We get the prime number from the input
+    let prime = UsefulConstants::new(&input_info.prime()).get_p().clone();
+    let result_program_archive = parser::run_parser(initial_file, VERSION, input_info.get_link_libraries().to_vec(), &prime, input_info.save_ast, input_info.ast_path.clone());
     match result_program_archive {
         Result::Err((file_library, report_collection)) => {
             Report::print_reports(&report_collection, &file_library);

circom_algebra/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "circom_algebra"
-version = "2.1.4"
+version = "2.2.0"
 authors = ["Costa Group UCM","iden3"]
 edition = "2018"
 

circom_algebra/src/algebra.rs

@@ -554,13 +554,13 @@ impl<C: Default + Clone + Display + Hash + Eq> ArithmeticExpression<C> {
     }
 
     // Bit operations
-    pub fn complement_254(
+    pub fn complement(
         elem: &ArithmeticExpression<C>,
         field: &BigInt,
     ) -> ArithmeticExpression<C> {
         use ArithmeticExpression::*;
         if let Number { value } = elem {
-            Number { value: modular_arithmetic::complement_254(value, field) }
+            Number { value: modular_arithmetic::complement(value, field) }
         } else {
             NonQuadratic
         }

circom_algebra/src/modular_arithmetic.rs

@@ -91,20 +91,20 @@ pub fn multi_inv(values: &Vec<BigInt>, field: &BigInt) -> Vec<BigInt>{
 }
 
 //Bit operations
-
-// 254 bit complement
-pub fn complement_254(elem: &BigInt, field: &BigInt) -> BigInt {
+pub fn complement(elem: &BigInt, field: &BigInt) -> BigInt {
     let (sign, mut bit_repr) = bit_representation(elem);
-    while bit_repr.len() > 254 {
+    let new_sign = if elem == &BigInt::from(0) { Sign::Plus } else { sign};
+    let nbits = field.bits();
+    while bit_repr.len() > nbits {
         bit_repr.pop();
     }
-    for _i in bit_repr.len()..254 {
+    for _i in bit_repr.len()..nbits {
         bit_repr.push(0);
     }
     for bit in &mut bit_repr {
         *bit = if *bit == 0 { 1 } else { 0 };
     }
-    let cp = BigInt::from_radix_le(sign, &bit_repr, 2).unwrap();
+    let cp = BigInt::from_radix_le(new_sign, &bit_repr, 2).unwrap();
     modulus(&cp, field)
 }
 
@@ -252,8 +252,8 @@ mod tests {
             .expect("generating the big int was not possible");
         let big_num = BigInt::parse_bytes("1234".as_bytes(), 10)
             .expect("generating the big int was not possible");
-        let big_num_complement = complement_254(&big_num, &field);
-        let big_num_complement_complement = complement_254(&big_num_complement, &field);
+        let big_num_complement = complement(&big_num, &field);
+        let big_num_complement_complement = complement(&big_num_complement, &field);
         let big_num_modulus = modulus(&big_num, &field);
         assert_eq!(big_num_complement_complement, big_num_modulus);
     }

code_producers/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "code_producers"
-version = "2.1.9"
+version = "2.2.0"
 authors = ["Costa Group UCM","iden3"]
 edition = "2018"