Skip to content

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jun 26, 2023

Description

The repo contains an empty mptt stub since app-helper automatically adds it to INSTALLED_APPS for test runs. Tests would fail w/o a (potentially empty) mptt package.

The manifest now excludes the stub from the filer package to not interfere with installations that need django-mptt for other reasons.

The mptt stub can be removed from the django-filer repo once app-helper is updated.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1367 (ef520b6) into master (0f679cd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          75       75           
  Lines        3408     3408           
  Branches      551      551           
=======================================
  Hits         2510     2510           
  Misses        727      727           
  Partials      171      171           
Impacted Files Coverage Δ
filer/models/abstract.py 81.60% <100.00%> (ø)

@fsbraun fsbraun requested a review from marksweb June 26, 2023 06:17
@fsbraun fsbraun changed the title fix: Update manifest to exclude mptt stub fix: Update manifest to exclude mptt stub in release package Jun 26, 2023
@fsbraun fsbraun requested a review from vinitkumar June 26, 2023 13:00
@fsbraun fsbraun merged commit f57ef38 into django-cms:master Jun 26, 2023
@fsbraun fsbraun deleted the fix/manifest branch June 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants