feat: import and export management commands (#1973) #1992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify book id, to avoid depending on next id.
bmihelac
force-pushed
the
feat/management-commands
branch
from
e2e4167 to
224a54a
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
477a7c9 to
643d08a
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
6360ca8 to
f9feca5
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
bed3e66 to
a5bf523
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
3eb645b to
2a17796
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
cab9129 to
99a5057
Compare
bmihelac
force-pushed
the
feat/management-commands
branch
from
438b17b to
0989f83
Compare
for more information, see https://pre-commit.ci
andrewgy8
approved these changes
Nov 6, 2024
|
Good work @bmihelac ! Lets see how the community uses this! 😄 |
|
It would be a good idea to add a confirmation prompt for the import command that would be skipped if the --noinput option is passed. |
|
Merged - @matthewhegarty and @andrewgy8 thanks for review! |
Viicos
added a commit
to Viicos/typeshed
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Feature proposal - import and export management command
Solution
As described. Additional
encodingargument is added to both commands.Acceptance Criteria
yes
yes