Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for new maintainer #424

Closed
mblayman opened this issue Apr 24, 2018 · 19 comments
Closed

Request for new maintainer #424

mblayman opened this issue Apr 24, 2018 · 19 comments

Comments

@mblayman
Copy link
Collaborator

I picked up the maintainer torch about a year ago when the project seemed to be stuck. I was using DJA on a side project, and I needed to fix a bug and get a new release out. Today, I'm no longer working on the side project and my interest in maintaining DJA has waned significantly.

As I'm not being a great steward for the project, I'd like to request that someone else pick it up. This is very much a community effort and code contributions come from a wide variety of contributors. The new maintainer would be most involved with:

  1. Review of new Pull Requests and Issues.
  2. Deploying new releases to PyPI.

I hope that I've added the right tools that can make management of this project easier for a future maintainer. Static code analysis has removed a lot of friction that might come up as a primary PR reviewer.

If you're in a decent place to step into the maintainer role, please let me know and I can work to transition over project handling to you. I'm happy to help with a bit of training if needed or improving release documentation.

@n2ygk
Copy link
Contributor

n2ygk commented Apr 24, 2018

@mblayman Are you the only one maintaining this? I see three other names (@gaker, @jerel, and @jsenecal) at https://github.com/orgs/django-json-api/people

I'd love to help out but I'm not sure I'm qualified (just look at how bad my PRs are;-) I don't have a ton of spare time but would hate to see this project founder.

Maybe this is a candidate to move to https://jazzband.co/ which is where django-oauth-toolkit recently moved. Or somehow get it adopted by http://www.django-rest-framework.org/?

@mblayman
Copy link
Collaborator Author

Yes, I think I'm the only active maintainer. My chronology may not be exactly right, but @gaker started the project, @jsenecal maintained it after that, @jerel followed him, and I picked it up from @jerel.

These guys chime in from time to time, but I don't believe that any of them are actively maintaining DJA.

Switching to Jazzband is probably a pretty solid idea if there is no one with the time availability to act as a regular maintainer.

@sliverc
Copy link
Member

sliverc commented Apr 25, 2018

I use DJA in several projects and therefore would be interested in a well maintained DJA. I do not think though I would have the time to be a sole active maintainer and I also think it won't be good for the project in the long run.

For the future of the project moving it to JazzBand could be a good idea. If it is decided to go down this way I would be willing to help out in the transition.

@n2ygk
Copy link
Contributor

n2ygk commented Apr 25, 2018

I would be happy to back you up @sliverc. I just joined Jazzband, FWIW.

@mblayman
Copy link
Collaborator Author

I'm happy to pass the baton to the two of you as you both have actively contributed within the last year. I think I would need to add you to the django-json-api team. Ultimately, I can give one or both of you the upload permission to the PyPI package.

I think I should probably start a CONTRIBUTING.md file so that if the team ultimately decides to move to Jazzband, that work will at least be done.

mblayman added a commit to mblayman/django-rest-framework-json-api that referenced this issue Apr 26, 2018
This branch adds a skeleton of contribution guidelines and cleans up
little bits that I noticed along the way.

For django-json-api#424
@sliverc
Copy link
Member

sliverc commented Apr 26, 2018

@mblayman If you could add me to the team and give PyPi upload rights that would be great.
I see when I get around but I will try to get the current PRs reviewed and get a release out.

I do not really wanna review my own PRs (would miss the whole point of reviews... :)) so I think it would be great if someone else would be regularly active to review those (someone who is already part of the team or @n2ygk if you see yourself in the position to review PRs and work through the open issues would be great too)

Once those tasks are cleared out we can then still consider whether it would be good to move to JazzBand or not. I hope though that the other team members might help out once in a while as well and then it might not be necessary.

@jerel
Copy link
Member

jerel commented Apr 26, 2018

Yes, I think I'm the only active maintainer. My chronology may not be exactly right, but @gaker started the project, @jsenecal maintained it after that, @jerel followed him, and I picked it up from @jerel.

Yeah, gaker and myself open sourced this project from a company that we worked together at. I still have DJA in production but that project is in maintenance mode so I don't have the time to focus on ongoing development here. Thanks to everyone who has stepped up to keep this library alive!

@simkimsia
Copy link

This is weird. I only recently looked at DJA just a week ago because I may need it in a project.

My situation is similar to @sliverc I be happy to help with transitioning this to jazzband. It's in my interest to see this well maintained.

I am not particularly skilled. but be happy with some simple grunt coding tasks if given some training.

mblayman added a commit that referenced this issue Apr 26, 2018
This branch adds a skeleton of contribution guidelines and cleans up
little bits that I noticed along the way.

For #424
@n2ygk
Copy link
Contributor

n2ygk commented Apr 26, 2018

@sliverc Happy to review your PRs.

@n2ygk
Copy link
Contributor

n2ygk commented Apr 28, 2018

@mblayman what are the next steps?

@mblayman
Copy link
Collaborator Author

@n2ygk I would add you to the django-json-api team, but I see that I don't have permission to do that.

@jerel, could you add @n2ygk and @sliverc to the DJA team?

@jerel
Copy link
Member

jerel commented Apr 30, 2018

Hmm, I thought you had access. Oh well, I added both. Thanks

@jsenecal
Copy link
Member

jsenecal commented May 1, 2018

Yes, I think I'm the only active maintainer. My chronology may not be exactly right, but @gaker started the project, @jsenecal maintained it after that, @jerel followed him, and I picked it up from @jerel.

Just like @jerel, the work I performed on DJA was for an ongoing project I had back then... Unfortunately that project has been since cancelled. I do chime in from time to time, and will continue to do so but @mblayman is right, we need someone with available hands to work on merging PRs and such.

@sliverc
Copy link
Member

sliverc commented May 2, 2018

I have now gone through all the open PRs and reviewed them resp. requested changes when needed. I will try to focus on the PRs and only when time permits will I get to the open issues. So if some off you can occasionally look at the issues and comment that would be great.

Only @gaker and @jerel actually are owner and can change settings.

There are currently two settings I would like to change:

  • Add all members of django-json-api organization to the Maintainers team (2 are missing)
  • Enforce pull requests being reviewed by someone from the Maintainers team before they are allowed to be merged.

Once this is done we could also use https://github.com/orgs/django-json-api/teams/maintainers for discussion within the team how we want to move forward. What do you think? This way we do not clutter the issues for discussions.

@gaker @jerel Could you change these settings or otherwise give someone else of the team rights to do so? Thanks.

@jerel
Copy link
Member

jerel commented May 3, 2018

@sliverc done

@sliverc
Copy link
Member

sliverc commented May 3, 2018

@jerel Thanks.

I suggest we could close this issue for now what you think? In the future we could ask contributors more actively whether they want to become maintainers to keep growing the team.

@jerel jerel closed this as completed May 3, 2018
@mblayman
Copy link
Collaborator Author

mblayman commented May 3, 2018

Thanks @sliverc and @n2ygk! I really appreciate you two stepping up to take care of this project.

@n2ygk
Copy link
Contributor

n2ygk commented May 6, 2018

@mblayman @jerel @sliverc something is broken with Travis: "continuous-integration/travis-ci Expected — Waiting for status to be reported" in #434. Any idea how to resolve this? Is this related to recent changes of maintainers?

@n2ygk n2ygk reopened this May 6, 2018
@n2ygk
Copy link
Contributor

n2ygk commented May 6, 2018

moved to maintainers group

@n2ygk n2ygk closed this as completed May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants