Change in how the renderer detects list data #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the renderer would check whether `view.action` was `'list'`, and if not it would assume the data was a single resource instance. This can cause problems when a custom route returns list data. With this commit, the renderer instead checks whether the serializer that produced that data has `many` set to True.
jsenecal
added a commit
that referenced
this pull request
Oct 9, 2015
Change in how the renderer detects list data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the renderer would check whether
view.actionwas'list',and if not it would assume the data was a single resource instance.
This can cause problems when a custom route returns list data.
With this commit, the renderer instead checks whether the serializer
that produced that data has
manyset to True.