Skip to content

Fix potential circular import edge-case #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2016
Merged

Fix potential circular import edge-case #201

merged 1 commit into from
Feb 6, 2016

Conversation

asteinlein
Copy link
Contributor

Fixes #158

@asteinlein
Copy link
Contributor Author

Just a note that I've spent 6 hours today trying to replicate the issue with tests in django-rest-framework-json-api without any success. The problem is visible specifically during testing in our rather complex app, which makes it really hard to reproduce. It seems to relate to when files are first imported, as it specifically fails during test collection in our suite.

At any rate, I'm not the only one having experience this ref #158, and the fix is simple enough and did indeed solve my case.

jsenecal added a commit that referenced this pull request Feb 6, 2016
Fix potential circular import edge-case
@jsenecal jsenecal merged commit c37d3f4 into django-json-api:develop Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants