Don't set id to None when it's not submitted with the request
#280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.50% (diff: 100%)@@ develop #280 diff @@
==========================================
Files 47 47
Lines 2255 2255
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2041 2041
Misses 214 214
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parser always sets
request.data['id']even for POST requests that often don't include it. This doesn't play well with some serializer options likedefault. Ifidis part ofserializer.initial_datathen it will not be replaced by the field's default value even if it isNone.